Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support for hash field expiration #2716

Merged
merged 16 commits into from
Aug 17, 2024
Merged

Feature: Support for hash field expiration #2716

merged 16 commits into from
Aug 17, 2024

Conversation

atakavci
Copy link
Contributor

@atakavci atakavci commented May 20, 2024 •
edited
Loading

Closes/Fixes #2715

this PR add support for a set of new commands related to expiration of individual members of hash

HashFieldExpire exposes the functionality of commands HPEXPIRE/HPEXPIREAT, for each specified field, it gets the value and sets the field's remaining time to live or expireation timestamp

HashFieldExpireTime exposes the functionality of command HPEXPIRETIME, for specified field, it gets the remaining time to live in milliseconds or expiration timestamp

HashFieldPersist exposes the functionality of command HPERSIST, for each specified field, it removes the expiration time

HashFieldTimeToLive expoes the functionality of command HPTTL, for specified field, it gets the remaining time to live in milliseconds or expiration timestamp

@atakavci
support for hash field expiration
4e3fa3a 
HEXPIRE, HPEXPIRE, HPEXPIREAT, HPEXPIREAT

hashfieldtest refactor

code format + unit tests refactored
@atakavci
add FIELDS
9b0baec
@atakavci
support for hash field expiration
1ae4d4a 
HPEXPIRETIME, HPTTL, HPERSIST, HGETF, HSETF
@atakavci
rename some methods and tidy up
7dbb7af
@mgravell
Copy link
Collaborator

I don't want to merge this until these commands actually land in redis, but we can certainly take a look at the proposal in advance of that 👍

@atakavci
Copy link
Contributor Author

sure!! aim is to be prepared for the time this feature get ready in Redis.
please take a look when you have time and i d be happy to get your thoughts !!

@atakavci atakavci requested a review from mgravell May 23, 2024 08:31
@uglide uglide mentioned this pull request Jun 13, 2024
Merged
@uglide
Copy link

uglide commented Jun 13, 2024

I don't want to merge this until these commands actually land in redis, but we can certainly take a look at the proposal in advance of that 👍

Redis 7.4-RC1 was released. See #2739

@atakavci atakavci mentioned this pull request Jun 20, 2024
Open
@NickCraver NickCraver changed the title support for hash field expiration Feature: Support for hash field expiration Jul 2, 2024
mgravell
mgravell requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@mgravell mgravell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of thoughts and nits; also aware that the whitespace deltas are going to compete with 2722 🤷

also: release notes

@atakavci
Copy link
Contributor Author

atakavci commented Aug 3, 2024

a couple of thoughts and nits; also aware that the whitespace deltas are going to compete with 2722 🤷

@mgravell, lets merge this one first if you are good with it. And i ll handle whitespaces with #2722.

@NickCraver
Copy link
Collaborator

@atakavci I'm about to merge the StyleCop bits in now (prepped locally), but I'll immediately fix this up and eat the merge on this end - not asking committers to do it :)

@NickCraver
Copy link
Collaborator

Updates pushed here - docs tweaked and release notes added as well - if builds are all good 👍on merging this in a bit.

@uglide
Copy link

uglide commented Aug 7, 2024

@NickCraver Could you merge this PR?

@NickCraver NickCraver merged commit e208905 into StackExchange:main Aug 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver left review comments

@mgravell mgravell mgravell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Hash Field Expiration commands
4 participants
@atakavci @mgravell @uglide @NickCraver